Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Agora bug fix #202

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Fix] Agora bug fix #202

wants to merge 4 commits into from

Conversation

pangyyyyy
Copy link
Collaborator

@pangyyyyy pangyyyyy commented Jun 27, 2022 •
edited
Loading

Fixes:

@pangyyyyy pangyyyyy requested a review from caizhongang June 27, 2022 05:28
@pangyyyyy pangyyyyy mentioned this pull request Jun 27, 2022
Open
@pangyyyyy pangyyyyy self-assigned this Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022 •
edited
Loading

Codecov Report

Merging #202 (f210de9) into main (21a8ce7) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   85.10%   85.04%   -0.06%     
==========================================
  Files         173      173              
  Lines       14826    14829       +3     
==========================================
- Hits        12618    12612       -6     
- Misses       2208     2217       +9
Flag Coverage Δ
unittests 85.04% <75.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uman3d/core/conventions/keypoints_mapping/agora.py 100.00% <ø> (ø)
mmhuman3d/data/data_converters/agora.py 87.76% <75.00%> (-0.35%) ⬇️
...man3d/data/datasets/pipelines/hybrik_transforms.py 90.31% <0.00%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a8ce7...f210de9. Read the comment docs.

@pangyyyyy pangyyyyy mentioned this pull request Jun 27, 2022
Open
@raulTrial
Copy link

raulTrial commented Jul 13, 2022 •
edited
Loading

hi @pangyyyyy, I'm not sure if this is taken into consideration, but the gender, might lead to errors down the pipeline as AGORA uses neutral model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caizhongang caizhongang Awaiting requested review from caizhongang

At least 1 approving review is required to merge this pull request.

Assignees

@pangyyyyy pangyyyyy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global orientation on AGORA is wrong Failure in training HMR on Agora dataset
2 participants
@pangyyyyy @raulTrial